cshuo commented on code in PR #19075:
URL: https://github.com/apache/hudi/pull/19075#discussion_r3480150120
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/ttl/strategy/KeepByTimeStrategy.java:
##########
@@ -46,7 +46,7 @@ public class KeepByTimeStrategy extends PartitionTTLStrategy {
public KeepByTimeStrategy(HoodieTable hoodieTable, String instantTime) {
super(hoodieTable, instantTime);
- this.ttlInMilis = writeConfig.getPartitionTTLStrategyDaysRetain() * 1000 *
3600 * 24;
+ this.ttlInMilis = (long) writeConfig.getPartitionTTLStrategyDaysRetain() *
1000 * 3600 * 24;
Review Comment:
Can you add a small regression test asserting `ttlInMilis > 0` (or the
expiration behavior) for `daysRetain = 25`, since this is an easy boundary to
lock down and
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
