hudi-agent commented on code in PR #19075:
URL: https://github.com/apache/hudi/pull/19075#discussion_r3484960601
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/ttl/strategy/KeepByTimeStrategy.java:
##########
@@ -46,7 +46,7 @@ public class KeepByTimeStrategy extends PartitionTTLStrategy {
public KeepByTimeStrategy(HoodieTable hoodieTable, String instantTime) {
super(hoodieTable, instantTime);
- this.ttlInMilis = writeConfig.getPartitionTTLStrategyDaysRetain() * 1000 *
3600 * 24;
+ this.ttlInMilis = (long) writeConfig.getPartitionTTLStrategyDaysRetain() *
1000 * 3600 * 24;
Review Comment:
🤖 nit: could you use
`TimeUnit.DAYS.toMillis(writeConfig.getPartitionTTLStrategyDaysRetain())` here?
It returns a `long` natively so the `(long)` cast disappears, and the intent is
clearer than three raw multipliers.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
