hudi-agent commented on code in PR #19184:
URL: https://github.com/apache/hudi/pull/19184#discussion_r3523507693
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/client/TestHoodieClientMultiWriter.java:
##########
@@ -1528,9 +1528,9 @@ private void runConcurrentAndAssert(JavaRDD<HoodieRecord>
writeRecords1, JavaRDD
try {
ingestBatch(writeFn, client1, newCommitTime1, writeRecords1,
runCountDownLatch);
} catch (IOException e) {
- LOG.error("IOException thrown " + e.getMessage());
+ LOG.error("IOException thrown {}", e.getMessage());
Review Comment:
🤖 nit: could you pass `e` directly as the final argument —
`LOG.error("IOException thrown", e)` — rather than `e.getMessage()`? SLF4J will
append the full stack trace automatically, which makes test failures much
easier to diagnose. Same applies to line 1533.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
