yihua commented on code in PR #19184:
URL: https://github.com/apache/hudi/pull/19184#discussion_r3523705387
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/client/TestHoodieClientMultiWriter.java:
##########
@@ -1528,9 +1528,9 @@ private void runConcurrentAndAssert(JavaRDD<HoodieRecord>
writeRecords1, JavaRDD
try {
ingestBatch(writeFn, client1, newCommitTime1, writeRecords1,
runCountDownLatch);
} catch (IOException e) {
- LOG.error("IOException thrown " + e.getMessage());
+ LOG.error("IOException thrown {}", e.getMessage());
Review Comment:
This is test class so it's ok to leave it as is.
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/client/functional/TestDataValidationCheckForLogCompactionActions.java:
##########
@@ -195,7 +195,7 @@ private boolean writeOnMainTable(TestTableContents
mainTable, int curr) throws I
result = deleteDataIntoMainTable(mainTable, commitTime);
}
} catch (IllegalArgumentException e) {
- LOG.warn(e.getMessage() + " ignoring current command.");
+ LOG.warn("{} ignoring current command.", e.getMessage());
Review Comment:
This is test class so it's ok to leave it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
