yihua commented on code in PR #19188:
URL: https://github.com/apache/hudi/pull/19188#discussion_r3523668432
##########
hudi-io/src/main/java/org/apache/hudi/common/util/ReflectionUtils.java:
##########
@@ -136,15 +136,15 @@ public static Stream<String>
getTopLevelClassesInClasspath(Class<?> clazz) {
try {
resources = classLoader.getResources(path);
} catch (IOException e) {
- log.error("Unable to fetch Resources in package " + e.getMessage());
+ log.error("Unable to fetch Resources in package {}", e.getMessage());
Review Comment:
+1 let's fis this
##########
hudi-io/src/main/java/org/apache/hudi/common/util/ReflectionUtils.java:
##########
@@ -136,15 +136,15 @@ public static Stream<String>
getTopLevelClassesInClasspath(Class<?> clazz) {
try {
resources = classLoader.getResources(path);
} catch (IOException e) {
- log.error("Unable to fetch Resources in package " + e.getMessage());
+ log.error("Unable to fetch Resources in package {}", e.getMessage());
}
List<File> directories = new ArrayList<>();
while (Objects.requireNonNull(resources).hasMoreElements()) {
URL resource = resources.nextElement();
try {
directories.add(new File(resource.toURI()));
} catch (URISyntaxException e) {
- log.error("Unable to get " + e.getMessage());
+ log.error("Unable to get {}", e.getMessage());
Review Comment:
+1 same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
