voonhous commented on code in PR #19188:
URL: https://github.com/apache/hudi/pull/19188#discussion_r3524388785
##########
hudi-io/src/main/java/org/apache/hudi/common/util/ReflectionUtils.java:
##########
@@ -136,15 +136,15 @@ public static Stream<String>
getTopLevelClassesInClasspath(Class<?> clazz) {
try {
resources = classLoader.getResources(path);
} catch (IOException e) {
- log.error("Unable to fetch Resources in package " + e.getMessage());
+ log.error("Unable to fetch Resources in package {}", e.getMessage());
Review Comment:
Good catch. Passed `e` as the trailing throwable so SLF4J logs the full
stack trace. Since `packageName` is already in scope I kept a `{}` for it (so
the message actually names the package rather than reading like it interpolates
one), giving `log.error("Unable to fetch Resources in package {}", packageName,
e)`. Applied the same treatment to the sibling `URISyntaxException` log a few
lines down (`"Unable to get URI for {}", resource, e`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
