hudi-agent commented on code in PR #19190: URL: https://github.com/apache/hudi/pull/19190#discussion_r3524437031
########## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/clustering/ClusteringPlanSourceFunction.java: ########## @@ -46,10 +45,9 @@ * as the instant time.</li> * </ul> */ +@Slf4j Review Comment: 🤖 nit: the original field was `protected static final Logger LOG`, meaning subclasses could reference it directly. `@Slf4j` generates `private static final Logger log`, so any existing or future subclass that relied on the inherited `LOG` would break silently at compile time. Could you confirm no subclasses reference `LOG`? If they do (or might), consider keeping the field as a manual `protected` declaration rather than using `@Slf4j` here. Same applies to `CompactionPlanSourceFunction`, `HoodieFlinkClusteringJob`, and `HoodieFlinkCompactor`. <sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
