voonhous commented on code in PR #19190: URL: https://github.com/apache/hudi/pull/19190#discussion_r3524749803
########## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/clustering/ClusteringPlanSourceFunction.java: ########## @@ -46,10 +45,9 @@ * as the instant time.</li> * </ul> */ +@Slf4j Review Comment: Confirmed - there are no subclasses of `ClusteringPlanSourceFunction`, `CompactionPlanSourceFunction`, `HoodieFlinkClusteringJob`, or `HoodieFlinkCompactor` anywhere in the repo (`grep -rn 'extends <class>'` returns nothing), so nothing references the inherited `LOG`. The `protected` was over-permissive; the generated `private log` is safe here. If a subclass ever needs a logger it just adds its own `@Slf4j` (each class gets its own `log`), so there's no cross-class dependency to preserve. Keeping `@Slf4j`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
