danny0405 commented on code in PR #19226:
URL: https://github.com/apache/hudi/pull/19226#discussion_r3556690650
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseRollbackPlanActionExecutor.java:
##########
@@ -103,7 +103,8 @@ protected Option<HoodieRollbackPlan> requestRollback(String
startRollbackTime) {
final HoodieInstant rollbackInstant =
instantGenerator.createNewInstant(HoodieInstant.State.REQUESTED,
HoodieTimeline.ROLLBACK_ACTION, startRollbackTime);
try {
List<HoodieRollbackRequest> rollbackRequests = new ArrayList<>();
- if (!instantToRollback.isRequested()) {
+ if (!instantToRollback.isRequested()
+ ||
HoodieTimeline.COMPACTION_ACTION.equals(instantToRollback.getAction())) {
Review Comment:
restore is not designed to rollback complete instant, did you mean
`RestoreToInstantProcedure`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
