danny0405 commented on code in PR #19226:
URL: https://github.com/apache/hudi/pull/19226#discussion_r3556691921
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/ListingBasedRollbackStrategy.java:
##########
@@ -98,16 +100,18 @@ public List<HoodieRollbackRequest>
getRollbackRequests(HoodieInstant instantToRo
try {
HoodieTableMetaClient metaClient = table.getMetaClient();
boolean isTableVersionLessThanEight =
metaClient.getTableConfig().getTableVersion().lesserThan(HoodieTableVersion.EIGHT);
- List<String> partitionPaths =
- FSUtils.getAllPartitionPaths(context, table.getMetaClient(), false);
+ HoodieTableType tableType = table.getMetaClient().getTableType();
+ String baseFileExtension = table.getBaseFileExtension();
+ Option<HoodieCommitMetadata> commitMetadataOptional =
+ !instantToRollback.isCompleted() ? Option.empty() :
getHoodieCommitMetadata(metaClient, instantToRollback);
+ Boolean isCommitMetadataCompleted =
checkCommitMetadataCompleted(instantToRollback, commitMetadataOptional);
+ List<String> partitionPaths = isCommitMetadataCompleted
Review Comment:
is this an optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
