yihua opened a new pull request, #19252:
URL: https://github.com/apache/hudi/pull/19252

   ### Describe the issue this Pull Request addresses
   
   issue: #18623
   
   Follow-up to the merged Vortex integration (#19182). A self-review of the 
merged code found that the `StoragePathInfo` overload of the file-reader 
factory does not dispatch VORTEX.
   
   ### Summary and Changelog
   
   - Add the missing `VORTEX` case to 
`HoodieFileReaderFactory#getFileReader(HoodieConfig, StoragePathInfo, 
HoodieFileFormat, Option)`, matching the `StoragePath` overload and the 
existing `LANCE` handling. Without it, a caller that starts from a listed 
`StoragePathInfo` gets `UnsupportedOperationException: VORTEX format not 
supported yet` instead of the Vortex reader.
   - Cover the overload in 
`TestVortexReaderWriterRoundTrip#testFactoryStoragePathInfoDispatch`: write a 
Vortex file, then read it back through 
`HoodieSparkFileReaderFactory.getFileReader(config, pathInfo, VORTEX, empty)`.
   - Clarify the `Spark3_5Adapter.createVortexFileReader` comment: the reason 
it returns `None` is that the adapter must stay compilable on the Java 11 Spark 
3.5 CI builds where `SparkVortexReaderBase` is excluded, not the runtime JDK of 
Spark 3.5.
   
   ### Impact
   
   Fixes a latent dispatch gap. Current callers of this overload pass HFILE or 
the metadata-table base format, so existing behavior is unchanged; VORTEX base 
files become readable through it.
   
   ### Risk Level
   
   low
   
   ### Documentation Update
   
   none
   
   ### Contributor's checklist
   
   - [x] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [x] Enough context is provided in the sections above
   - [x] Adequate tests were added if applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to