fhan688 commented on code in PR #19041:
URL: https://github.com/apache/hudi/pull/19041#discussion_r3612048619
##########
hudi-common/src/main/java/org/apache/hudi/common/util/CleanerUtils.java:
##########
@@ -167,6 +170,10 @@ public static Option<HoodieInstant>
getEarliestCommitToRetain(
return earliestCommitToRetain;
}
+ private static String getCompletionTimeOrRequestedTime(HoodieInstant
instant) {
+ return StringUtils.isNullOrEmpty(instant.getCompletionTime()) ?
instant.requestedTime() : instant.getCompletionTime();
Review Comment:
Yes, you are right. A completed instant loaded from the active timeline
already has a completion time. Timeline V2 reads it from the instant filename
and derives it from the file modification time for legacy instant files;
Timeline V1 also provides the state transition time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
