fhan688 commented on code in PR #19041:
URL: https://github.com/apache/hudi/pull/19041#discussion_r3620156824
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/common/testutils/HoodieMetadataTestTable.java:
##########
@@ -175,7 +175,17 @@ public HoodieTestTable addReplaceCommit(
Option<HoodieRequestedReplaceMetadata> requestedReplaceMetadata,
Option<HoodieCommitMetadata> inflightReplaceMetadata,
HoodieReplaceCommitMetadata completeReplaceMetadata) throws Exception {
- super.addReplaceCommit(instantTime, requestedReplaceMetadata,
inflightReplaceMetadata, completeReplaceMetadata);
+ return addReplaceCommit(instantTime, Option.empty(),
requestedReplaceMetadata, inflightReplaceMetadata, completeReplaceMetadata);
+ }
+
+ @Override
+ public HoodieTestTable addReplaceCommit(
Review Comment:
> is the change related with the cleaner change?
Yes, this change is directly related to the cleaner fix.
`testKeepXHoursWithDeletePartition` needs to create delete-partition
replace commits with deterministic completion times, since
`KEEP_LATEST_BY_HOURS` now evaluates completed instants using completion time.
The completion-time overload of `HoodieTestTable.addDeletePartitionCommit`
delegates to the corresponding `addReplaceCommit` overload.
`HoodieMetadataTestTable` therefore needs to override this overload as
well. Otherwise, the call falls back to the base implementation and bypasses
the metadata-writer update performed by this subclass. The override preserves
both the explicit completion time and the existing metadata table update
behavior required by the cleaner test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
