fhan688 commented on code in PR #19041:
URL: https://github.com/apache/hudi/pull/19041#discussion_r3620165033
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java:
##########
@@ -1067,6 +1069,20 @@ public class FlinkOptions extends HoodieConfig {
.withFallbackKeys("hoodie.clean.fileversions.retained")
.withDescription("Number of file versions to retain. default 5");
+ public static final ConfigOption<Long> CLEAN_MAX_COMMITS_TO_CLEAN =
ConfigOptions
Review Comment:
> are these Flink option definitions still necessary, all the Hudi core
options are applied automatically for Flink.
You are right. `FlinkWriteClients` already passes
`flinkConf2TypedProperties(conf)` to `HoodieWriteConfig.Builder.withProps`, so
Hudi core properties are applied automatically for Flink.
I removed the duplicate Flink option definitions and the corresponding
explicit cleaner/archiver builder mappings. I kept a focused test that sets the
`HoodieCleanConfig` and `HoodieArchivalConfig` core keys directly and verifies
that they are propagated to `HoodieWriteConfig`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
