danny0405 commented on code in PR #19392:
URL: https://github.com/apache/hudi/pull/19392#discussion_r3671120719
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/configuration/TestOptionsResolver.java:
##########
@@ -270,4 +283,136 @@ void testEstimateFileGroupCountForGlobalRLI() {
conf.setString(HoodieMetadataConfig.GLOBAL_RECORD_LEVEL_INDEX_MAX_FILE_GROUP_COUNT_PROP.key(),
"11");
assertEquals(11, OptionsResolver.estimateFileGroupCountForRLI(conf));
}
+
+ @Test
+ void testIncrementalJobGraphPredicate() {
+ Configuration conf = new Configuration();
+ assertFalse(OptionsResolver.isIncrementalJobGraph(conf));
+ conf.set(FlinkOptions.WRITE_INCREMENTAL_JOB_GRAPH_GENERATION, true);
+ assertTrue(OptionsResolver.isIncrementalJobGraph(conf));
+ }
+
+ @Test
+ void testTableTypePredicates() {
+ Configuration conf = new Configuration();
+ assertTrue(OptionsResolver.isCowTable(conf));
+ assertFalse(OptionsResolver.isMorTable(conf));
+ assertFalse(OptionsResolver.isMorTable(Collections.emptyMap()));
+ conf.set(FlinkOptions.TABLE_TYPE,
HoodieTableType.MERGE_ON_READ.name().toLowerCase());
+ assertTrue(OptionsResolver.isMorTable(conf));
+ assertTrue(OptionsResolver.isMorTable(
+ Collections.singletonMap(FlinkOptions.TABLE_TYPE.key(),
HoodieTableType.MERGE_ON_READ.name())));
+ }
+
+ @Test
+ void testOperationTypePredicates() {
+ Configuration conf = new Configuration();
+ conf.set(FlinkOptions.OPERATION, WriteOperationType.INSERT.value());
+ assertTrue(OptionsResolver.isInsertOperation(conf));
+ conf.set(FlinkOptions.OPERATION, WriteOperationType.UPSERT.value());
+ assertTrue(OptionsResolver.isUpsertOperation(conf));
+ conf.set(FlinkOptions.OPERATION, WriteOperationType.BULK_INSERT.value());
+ assertTrue(OptionsResolver.isBulkInsertOperation(conf));
+ }
+
+ @Test
+ void testPayloadAndCompactionPredicates() {
+ Configuration conf = new Configuration();
+ conf.set(FlinkOptions.PAYLOAD_CLASS_NAME,
DefaultHoodieRecordPayload.class.getName());
+ assertTrue(OptionsResolver.isDefaultHoodieRecordPayloadClazz(conf));
+ conf.set(FlinkOptions.COMPACTION_TRIGGER_STRATEGY,
FlinkOptions.TIME_ELAPSED.toUpperCase());
+ assertTrue(OptionsResolver.isDeltaTimeCompaction(conf));
+ conf.set(FlinkOptions.COMPACTION_TRIGGER_STRATEGY,
FlinkOptions.NUM_COMMITS);
+ assertFalse(OptionsResolver.isDeltaTimeCompaction(conf));
+ }
+
+ @Test
+ void testReadOptions() {
+ Configuration conf = new Configuration();
+ assertEquals(-1, OptionsResolver.getReadCommitsLimit(conf));
+ conf.set(FlinkOptions.READ_COMMITS_LIMIT, 5);
+ assertEquals(5, OptionsResolver.getReadCommitsLimit(conf));
+
+ conf.set(FlinkOptions.SUPPLEMENTAL_LOGGING_MODE,
+
HoodieCDCSupplementalLoggingMode.DATA_BEFORE_AFTER.name().toLowerCase());
+ assertEquals(HoodieCDCSupplementalLoggingMode.DATA_BEFORE_AFTER,
+ OptionsResolver.getCDCSupplementalLoggingMode(conf));
+
+ conf.set(FlinkOptions.READ_CDC_FROM_CHANGELOG, false);
+ assertFalse(OptionsResolver.readCDCFromChangelog(conf));
+ conf.set(FlinkOptions.RECORD_KEY_FIELD, "id,tenant");
+ assertEquals("id", OptionsResolver.getIndexKeyFields(conf).get(0));
+ assertEquals("tenant", OptionsResolver.getIndexKeyFields(conf).get(1));
Review Comment:
Addressed in 5abb17b0d55b. I split the method into focused tests for write
flags and concurrency-control modes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
