danny0405 commented on code in PR #19392:
URL: https://github.com/apache/hudi/pull/19392#discussion_r3688958665
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/StreamerUtil.java:
##########
@@ -135,7 +135,13 @@ public static TypedProperties
appendKafkaProps(FlinkStreamerConfig config) {
public static TypedProperties getProps(FlinkStreamerConfig cfg) {
if (cfg.propsFilePath.isEmpty()) {
- return new TypedProperties();
+ TypedProperties properties = new TypedProperties();
+ cfg.configs.forEach(x -> {
+ String[] kv = x.split("=");
Review Comment:
[P1] Split `--hoodie-conf` only on the first `=`. `String.split("=")`
rejects valid values that contain another `=` (for example a URL/query string
or JSON expression), and because Java drops trailing empty fields it also
rejects an intentionally empty value such as
`hoodie.datasource.write.partitionpath.field=`. The `--props` path parses both
cases successfully, so the behavior now depends on whether a props file was
supplied. Please use `split("=", 2)` (and add coverage for embedded/empty
values) so the no-file path preserves the complete value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
