hudi-agent commented on code in PR #19390:
URL: https://github.com/apache/hudi/pull/19390#discussion_r3682157620
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/OptionsResolver.java:
##########
@@ -166,13 +166,13 @@ public static boolean isCowTable(Configuration conf) {
/**
* Returns the configured table storage layout.
*
- * <p>Insert and bulk insert operations preserve duplicate record keys and
therefore default to
- * the regular storage layout. Other operations use Flink's LSM tree default.
+ * <p>Insert operations preserve duplicate record keys and therefore default
to the regular
+ * storage layout. Other operations use Flink's LSM tree default.
*/
public static HoodieTableConfig.TableStorageLayout
getTableStorageLayout(Configuration conf) {
return HoodieTableConfig.TableStorageLayout.fromConfigValue(conf.getString(
HoodieTableConfig.TABLE_STORAGE_LAYOUT.key(),
- (isInsertOperation(conf) || isBulkInsertOperation(conf))
+ isInsertOperation(conf)
Review Comment:
🤖 Now that a new `bulk_insert` table defaults to (and persists) the LSM
layout, does a later `insert` job on the same path get rejected by
`checkStorageLayout`? Previously bulk_insert created a default-layout table
that accepted `insert`; is breaking the bulk_insert-bootstrap-then-insert
workflow intended (with explicit `hoodie.table.storage.layout=default` as the
escape hatch)?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
