cshuo commented on code in PR #19390: URL: https://github.com/apache/hudi/pull/19390#discussion_r3687939749
########## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/bulk/sort/LsmBulkInsertSortUtils.java: ########## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.sink.bulk.sort; + +import org.apache.flink.table.api.DataTypes; +import org.apache.flink.table.types.logical.LogicalType; +import org.apache.flink.table.types.logical.RowType; + +/** + * Utilities for defining and sorting the internal rows used by Flink LSM bulk insert. + * + * <p>Each internal row contains a shuffle key, the actual encoded record key, and the original + * table row. The shuffle key is the partition path for the regular bulk-insert path and the file ID + * for the bucket-index path. The external sorter orders rows by the shuffle key first and the + * record key second, so records for each shuffle key form a record-key-ordered run. + * + * <p>The original table row remains nested in the internal row and is not part of the sort key. + * After sorting, the LSM writer helpers consume the internal row directly and reuse the retained + * record key. + */ +public final class LsmBulkInsertSortUtils { + + public static final String FILE_GROUP_META_FIELD = "_fg"; + public static final String PARTITION_META_FIELD = "_partition"; + public static final String RECORD_KEY_FIELD = "_record_key"; + public static final String RECORD_FIELD = "record"; + + private LsmBulkInsertSortUtils() { + } + + /** + * Returns the internal row type passed from LSM key decoration through the external sorter. + * + * <p>The fields are ordered as shuffle key, encoded record key, and original table row. + * + * @param rowType logical type of the original table row + * @param shuffleKeyField field name for the partition path or file group + * @return logical type of the internal LSM sort row + */ + public static RowType sortRowType(RowType rowType, String shuffleKeyField) { Review Comment: Fixed in badecf916b14. Moved the non-bucket row-type/sorter methods into LsmBulkInsertWriterHelper and the bucket-specific methods into LsmBucketBulkInsertWriterHelper, then removed LsmBulkInsertSortUtils. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
