wombatu-kun commented on code in PR #19420: URL: https://github.com/apache/hudi/pull/19420#discussion_r3701117721
########## .gitignore: ########## @@ -3,7 +3,14 @@ target/ metastore_db/ .metals/ +# Keep ignoring .mvn directories anywhere in the tree (maven wrapper, IDE output, and Review Comment: This attributes the un-anchored `.mvn/` to local build output, but the reason it cannot be narrowed is that apache-rat reads .gitignore and hudi-trino/.mvn/modernizer/*.xml are tracked with no ASF header. Name apache-rat here so the next cleanup does not re-break validate-source. ########## .gitignore: ########## @@ -3,7 +3,14 @@ target/ metastore_db/ .metals/ +# Keep ignoring .mvn directories anywhere in the tree (maven wrapper, IDE output, and +# nested ones such as hudi-trino/.mvn), while tracking the repo-root .mvn/extensions.xml: +# that directory must exist for maven.multiModuleProjectDirectory to resolve to the repo +# root when a build runs from inside a submodule (HUDI-6111). .mvn/ +!/.mvn/ Review Comment: The Summary section still describes the first version of this change (`.mvn/*` plus `!.mvn/extensions.xml`), not the four-line pattern shipped here. Fold in the second commit's reason - apache-rat reads .gitignore, and narrowing it un-hid hudi-trino/.mvn/modernizer/*.xml - so the body matches the head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
