rangareddy commented on code in PR #19420:
URL: https://github.com/apache/hudi/pull/19420#discussion_r3701487240
##########
.gitignore:
##########
@@ -3,7 +3,14 @@
target/
metastore_db/
.metals/
+# Keep ignoring .mvn directories anywhere in the tree (maven wrapper, IDE
output, and
Review Comment:
Done — the comment now names apache-rat as the reason the entry cannot be
narrowed:
```
# Track the repo-root .mvn/extensions.xml: that directory must exist for
# maven.multiModuleProjectDirectory to resolve to the repo root when a build
runs from inside a
# submodule (HUDI-6111).
# Keep the un-anchored `.mvn/` entry. A pattern containing a slash is
anchored to this file's
# directory, so narrowing it to `.mvn/*` would stop matching nested .mvn
directories -- and
# apache-rat reads .gitignore, so that un-hides
hudi-trino/.mvn/modernizer/*.xml, which are tracked
# without ASF headers, and validate-source fails.
```
That is exactly how the first revision broke `validate-source` ("Too many
files with unapproved license: 2"), so it is worth having in the file rather
than only in the PR history.
##########
.gitignore:
##########
@@ -3,7 +3,14 @@
target/
metastore_db/
.metals/
+# Keep ignoring .mvn directories anywhere in the tree (maven wrapper, IDE
output, and
+# nested ones such as hudi-trino/.mvn), while tracking the repo-root
.mvn/extensions.xml:
+# that directory must exist for maven.multiModuleProjectDirectory to resolve
to the repo
+# root when a build runs from inside a submodule (HUDI-6111).
.mvn/
+!/.mvn/
Review Comment:
Good catch — the body has been rewritten to describe the shipped four-line
pattern, with the two constraints that produce it: git cannot re-include a file
whose parent directory is excluded by a `dir/` pattern (hence `!/.mvn/` before
`/.mvn/*`), and apache-rat reading `.gitignore` is why the un-anchored `.mvn/`
has to stay. It also now records the `validate-source` failure from the first
revision, so the reasoning is not only in the commit log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
