pengzhiwei2018 commented on a change in pull request #2645:
URL: https://github.com/apache/hudi/pull/2645#discussion_r601154948



##########
File path: 
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java
##########
@@ -617,6 +619,16 @@ public PropertyBuilder setTableName(String tableName) {
       return this;
     }
 
+    public PropertyBuilder setTableSchema(String tableSchema) {
+      this.tableSchema = tableSchema;
+      return this;
+    }
+
+    public PropertyBuilder setRowKeyFields(String rowKeyFields) {

Review comment:
       Hi @vinothchandar , I am afraid we cannot do this for sql. The common 
way to specify the primary key in sql is by the row key fields, just like most 
of the database does. I think we should not provide the generator class for 
user to specify the primary key in sql.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to