pengzhiwei2018 commented on pull request #2645: URL: https://github.com/apache/hudi/pull/2645#issuecomment-806471861
> @pengzhiwei2018 it's a great work, thanks. MERGE/DELETE expresssions(MergeIntoTable, MergeAction... ) in your pr is copy from v2Commands.scala in spark 3.0 which will lead to class conflict if we implement sql suppor for spark3 later. could you shade those keywords > > @vinothchandar > MERGE/DELETE keywords from Spark 3 is incompatible with this pr， however it's not a problem,we can introduce a extra module hudi-spark3-extensions to resolve those incompatible, i will put forward a new pr for spark3 next few days。 Hi @xiarixiaoyao , Thanks for the review! There is already exists a `hudi-spark3` module in the hudi project. I think we should not need to add a hudi-spark3-extensions. The `MergeIntoTable` has the same package and class name with the that in spark3, So that they can use the same rules `HoodieAnalysis` for resolve and rewrite. I think it will not conflict with the spark3 because we will not build the spark2 module together with the spark3. Only one `MergeIntoTable` will package in the bundle jar. > MERGE/DELETE keywords from Spark 3 is incompatible with this pr I am not understand the incompatible. They have the same syntax and logical plan between spark2 and spark3. Can your help me out? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
