hudi-agent commented on code in PR #19492:
URL: https://github.com/apache/hudi/pull/19492#discussion_r3706484984
##########
hudi-io/pom.xml:
##########
@@ -116,6 +116,10 @@
<goal>shade</goal>
</goals>
<configuration>
+ <!-- shadedArtifactAttached publishes the shaded jar under the
"shaded" classifier while the
+ primary jar stays unshaded, so the published POM must still
declare protobuf-java;
Review Comment:
🤖 nit: this comment is a bit long and winding — could you trim it to the one
non-obvious point (shaded jar is attached under a classifier so the primary POM
must keep protobuf-java, hence no reduced POM)? The "iff"/"packaging bundles
differ" phrasing is hard to parse.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
