hudi-agent commented on code in PR #19482:
URL: https://github.com/apache/hudi/pull/19482#discussion_r3708885923
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/format/cdc/CdcIterators.java:
##########
@@ -728,6 +734,14 @@ protected RowData getBeforeImage(RowKind rowKind,
HoodieCDCLogRecord<?> cdcRecor
}
}
+ private static void closeSuppressing(ClosableIterator<?> iterator, Throwable
primary) {
Review Comment:
🤖 nit: this exact `closeSuppressing(ClosableIterator, Throwable)` helper is
now duplicated verbatim in CdcInputFormat and HoodieCdcSplitReaderFunction too
— could you pull it into a shared util (e.g. a CollectionUtils/IOUtils-style
helper) so there's a single copy?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
