danny0405 commented on code in PR #19482:
URL: https://github.com/apache/hudi/pull/19482#discussion_r3708938470
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/format/cdc/CdcIterators.java:
##########
@@ -728,6 +734,14 @@ protected RowData getBeforeImage(RowKind rowKind,
HoodieCDCLogRecord<?> cdcRecor
}
}
+ private static void closeSuppressing(ClosableIterator<?> iterator, Throwable
primary) {
Review Comment:
Fixed in f96df25eaa6a. Added shared
`CloseableUtils.closeSuppressing(AutoCloseable, Throwable)` in hudi-common and
replaced the duplicate helpers in the CDC readers/iterators and spillable-map
failure path. I also reused it for the existing split-reader cleanup and added
`TestCloseableUtils` to verify suppression behavior. The Flink reactor
compile/style checks and all 13 focused CDC lifecycle tests pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
