danny0405 opened a new pull request, #19504: URL: https://github.com/apache/hudi/pull/19504
### Describe the issue this Pull Request addresses PR #12543 reordered the components used to construct several metric names. Although it was marked as a minor change, it changed existing timer and counter names in Hudi 1.x, breaking dashboards and alerts carried forward from 0.x. Compaction counters also gained a duplicated `compaction.compaction` segment. This PR restores the pre-#12543 names for metrics that already had a compatibility contract while preserving the naming of metrics added after #12543. ### Summary and Changelog - Restore type-first timer and counter names in `HoodieMetrics`, including compaction and conflict-resolution counters. - Restore legacy timer and counter names in `HoodieMetaSyncMetrics` and legacy timer names in `HoodieStreamerMetrics`. - Preserve action-first names for metrics added after #12543. - Add literal regression assertions for prefixed and unprefixed metric names and update the compactor metric assertion. - No code was copied. ### Impact Restores 0.x-compatible names such as `timer.commit`, `counter.compaction.requested`, and `counter.conflict_resolution.success`. Dashboards and alerts using the pre-#12543 names work across the 1.x upgrade. Consumers that adopted the post-#12543 names for these existing metrics will need to switch back to the legacy names. There are no public API, configuration, storage-format, or performance changes. Metrics introduced after #12543 retain their current names. ### Risk Level medium The change intentionally alters emitted names for the affected pre-existing metrics. The compatibility boundary is covered by literal name assertions with and without prefixes, and by the following focused test suites: - `TestHoodieMetrics` (25 tests) - `TestHoodieMetaSyncMetrics` (3 tests) - `TestHoodieStreamerMetrics` (7 tests) - `TestHoodieCompactor` (11 tests) ### Documentation Update none. This restores the established metric naming contract and does not introduce a feature, configuration, or new metric. ### Contributor's checklist - [x] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute) - [x] Enough context is provided in the sections above - [x] Adequate tests were added if applicable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
