hudi-agent commented on code in PR #19489: URL: https://github.com/apache/hudi/pull/19489#discussion_r3710738542
########## docker/README.md: ########## @@ -27,21 +27,15 @@ docker demo environment. The `/hoodie` folder contains all the configs for assembling necessary docker images. The name and repository of each docker image, e.g., `apachehudi/hudi-hadoop_2.8.4-prestobase_0.232`, is defined in the maven configuration file `pom.xml`. -### Base images by Java version +### Base image -`build_docker_images.sh` auto-selects one of the two supported base images from `--spark-version`: - -| Base module | JDK | Used for | -|---------------|---------|------------| -| `base_java11` | Java 11 | Spark 3.x | -| `base_java17` | Java 17 | Spark 4.0+ | +`build_and_publish_docker_images.sh` builds the `base_java11` module, which is what Spark 3.x needs. Review Comment: 🤖 This now says the script just "builds the `base_java11` module," but `build_and_publish_docker_images.sh` still auto-selects `base_java17` / `BASE_IMAGE_TAG=java17` when `--spark-version` is 4.x (the `SPARK_MAJOR -ge 4` branch), and that flag still accepts 4.x. Was dropping the Java 17 base from the docs intentional, or should this section still mention that a 4.x `--spark-version` switches to `base_java17`? <sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
