deepakpanda93 commented on code in PR #19489:
URL: https://github.com/apache/hudi/pull/19489#discussion_r3713204015
##########
docker/README.md:
##########
@@ -27,21 +27,15 @@ docker demo environment.
The `/hoodie` folder contains all the configs for assembling necessary docker
images. The name and repository of each
docker image, e.g., `apachehudi/hudi-hadoop_2.8.4-prestobase_0.232`, is
defined in the maven configuration file `pom.xml`.
-### Base images by Java version
+### Base image
-`build_docker_images.sh` auto-selects one of the two supported base images
from `--spark-version`:
-
-| Base module | JDK | Used for |
-|---------------|---------|------------|
-| `base_java11` | Java 11 | Spark 3.x |
-| `base_java17` | Java 17 | Spark 4.0+ |
+`build_and_publish_docker_images.sh` builds the `base_java11` module, which is
what Spark 3.x needs.
Review Comment:
Good catch, and the drift was mine — `473008de97fe` took the Java 17 base
out of the README but left the `SPARK_MAJOR -ge 4` branch in the script, so the
two disagreed.
Resolved in favour of the script, because that branch is live rather than
dead: `docker/hoodie/hadoop/base_java17` exists and the selection is reachable
through `--spark-version 4.x`. Verified by running it:
```
$ ./build_and_publish_docker_images.sh --version-tag t1 --spark-version
4.0.1 --publish false
Using Java 17 base image for Spark 4.0.1
Building hoodie/hadoop/base_java17 as:
- apachehudi/hudi-hadoop_3.3.4-base-java17:latest
```
The section now reads:
> `build_and_publish_docker_images.sh` picks the base module from
`--spark-version`: `base_java11` for Spark 3.x, which is the default and what
the compose files under `/compose` use, and `base_java17` for a 4.x version.
The demo compose files are all Spark 3.x, so the Java 17 base is only reached
if you ask for a 4.x `--spark-version` explicitly.
That keeps the docs truthful about what the script does without presenting
Spark 4 as a supported demo path, which was the intent behind removing it in
the first place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
