pkgajulapalli commented on PR #19571: URL: https://github.com/apache/hudi/pull/19571#issuecomment-5239147576
> **Re:** [nit about lifting the cause strings into constants](https://github.com/apache/hudi/pull/19571#discussion_r3748698568) Good catch — done in d5e5c40. All four are now `@VisibleForTesting` package-private constants declared together next to the other lock tunables (`THROTTLE_MAX_RETRIES`, `THROTTLE_INITIAL_RETRY_DELAY_SECONDS`), each with a one-line comment on what it means: ```java static final String CAUSE_HEARTBEAT_STOP_FAILED = "HEARTBEAT_STOP_FAILED"; static final String CAUSE_INTERRUPTED_DURING_THROTTLE_BACKOFF = "INTERRUPTED_DURING_THROTTLE_BACKOFF"; static final String CAUSE_THROTTLE_RETRIES_EXHAUSTED = "THROTTLE_RETRIES_EXHAUSTED"; static final String CAUSE_EXPIRE_WRITE_FAILED = "EXPIRE_WRITE_FAILED"; ``` Both the four call sites and the four test assertions now reference the constants instead of raw literals, so a rename fails at compile time rather than at runtime — which was the substantive part of your point. Emitted strings are unchanged. Re-verified: 48 tests, 0 failures, 0 errors. _(Posting at PR level: the force-push that carried this fix orphaned the commit the inline thread was anchored to.)_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
