hudi-agent commented on code in PR #19574:
URL: https://github.com/apache/hudi/pull/19574#discussion_r3751640626
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/StorageBasedLockProvider.java:
##########
@@ -498,8 +524,16 @@ public void unlock() {
}
if (expireResult != ExpireLockResult.SUCCESS) {
+ // THROTTLED here means the retries above were exhausted; FAILED means
tryExpireCurrentLock
+ // already logged the specific storage outcome (UNKNOWN_ERROR vs
ACQUIRED_BY_OTHERS).
+ String cause = expireResult == ExpireLockResult.THROTTLED
+ ? CAUSE_THROTTLE_RETRIES_EXHAUSTED
Review Comment:
🤖 nit: `cause` is computed just above but then omitted from the log message
— only `expireResult` (the enum) appears. Could you add `cause` as a
placeholder so the cause string (e.g. `THROTTLE_RETRIES_EXHAUSTED`) is
greppable directly in logs, without having to correlate with the exception?
e.g. `"... ended as {} (cause={}) after ..."` with args `expireResult, cause`.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
