fhan688 commented on PR #19041:
URL: https://github.com/apache/hudi/pull/19041#issuecomment-5279153769
> > > please help review again, thanks! @danny0405
> >
> >
> > should we just close this PR?
>
> looks like a test enhancement, can we fix the PR title and the context
description.
Thanks for the suggestion. I have updated the PR scope to make the actual
change clearer.
The PR title is now:
`fix(clean): use completion time for KEEP_LATEST_BY_HOURS retention`
I also rewrote the PR description to clarify that this is a focused
behavior fix rather than a new clean-by-time or archival feature. The only
production logic change is that `KEEP_LATEST_BY_HOURS` uses completion time to
determine which completed instants are inside the retention window, while ECTR
remains a requested-time boundary.
The remaining changes provide regression coverage and deterministic
completion times for synthetic test instants. I also removed the unrelated
Flink configuration propagation test, so the PR no longer contains any
Flink-specific changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
