voonhous commented on code in PR #19620:
URL: https://github.com/apache/hudi/pull/19620#discussion_r3793816514
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/dml/schema/TestVariantDataType.scala:
##########
@@ -1250,6 +1184,34 @@ class TestVariantDataType extends HoodieSparkSqlTestBase
{
})
}
+ /**
+ * Pins the on-disk layout of the `v` column across every base file. Without
it a leg meant to
+ * exercise the shredded path can silently degenerate into the unshredded
one, or the reverse,
+ * and the branch it was written for goes uncovered.
+ */
+ private def assertVariantLayout(tablePath: String, shredded: Boolean, leg:
String): Unit = {
Review Comment:
Folded in 4da5636.
##########
hudi-spark-datasource/hudi-spark4-common/src/test/java/org/apache/hudi/io/storage/hadoop/TestHoodieVariantReconstructionRoundTrip.java:
##########
@@ -104,6 +105,70 @@ void
createThenReconstructRebuildsVariantAndPassesThroughNonVariant(@TempDir Pat
assertEquals(original.toJson(ZoneOffset.UTC),
rebuilt.toJson(ZoneOffset.UTC));
}
+ @Test
+ void createThenReconstructRebuildsAValueLessShreddedGroup(@TempDir Path tmp)
throws Exception {
Review Comment:
Went with the CI option in 4da5636: added the module to the spark4.2 entry
of test-spark-java17-java-tests-part1. That is the only lane where java UTs run
off an exclusion filter (part2 pins three named classes, part3 runs the
functional profiles), and the module was already built there via -am since
spark4.2.x depends on it, so listing it in the test -pl is all that was
missing. Its surefire skip property (skip.hudi-spark4.unit.tests) defaults to
skipTests, which the test step does not set, so both test classes in the module
now execute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
