wombatu-kun commented on code in PR #19620:
URL: https://github.com/apache/hudi/pull/19620#discussion_r3793934063
##########
.github/workflows/bot.yml:
##########
@@ -732,9 +732,12 @@ jobs:
# - scalaProfile: "scala-2.13"
# sparkProfile: "spark4.1"
# sparkModules: "hudi-spark-datasource/hudi-spark4.1.x"
+ # hudi-spark4-common runs here (and only here): the other spark
lanes either pin a
+ # fixed test-class list or run scala/functional profiles, so without
this entry the
+ # module's java unit tests are compiled but never executed in CI.
- scalaProfile: "scala-2.13"
sparkProfile: "spark4.2"
- sparkModules: "hudi-spark-datasource/hudi-spark4.2.x"
+ sparkModules:
"hudi-spark-datasource/hudi-spark4-common,hudi-spark-datasource/hudi-spark4.2.x"
Review Comment:
The Summary and Changelog does not mention that this PR now edits bot.yml to
add hudi-spark4-common to the spark4.2 java-test lane, which starts running its
two test classes on every PR. Worth a bullet there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
