hudi-agent commented on code in PR #18396:
URL: https://github.com/apache/hudi/pull/18396#discussion_r3795447840


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAbstractMergeHandle.java:
##########
@@ -46,6 +46,12 @@
 @Slf4j
 public abstract class HoodieAbstractMergeHandle<T, I, K, O> extends 
HoodieWriteHandle<T, I, K, O> implements HoodieMergeHandle<T, I, K, O> {
 
+  // The number of incoming update and delete records based on tagging; see the
+  // MergeContext#numUpdates javadoc for the exact semantics (lower bound, not 
iterator size).

Review Comment:
   🤖 nit: `MergeContext#numUpdates` points to a private field — could you 
change it to `MergeContext#getNumUpdates()` so the reference resolves to the 
public accessor and its Javadoc in IDEs?
   
   <sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag 
quality.</i></sub>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to