voonhous commented on code in PR #18396:
URL: https://github.com/apache/hudi/pull/18396#discussion_r3795599119
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/TestUpdateSchemaEvolution.java:
##########
@@ -122,7 +124,7 @@ private void
assertSchemaEvolutionOnUpdateResult(WriteStatus insertResult, Hoodi
jsc.parallelize(Arrays.asList(1)).map(x -> {
Executable executable = () -> {
HoodieWriteMergeHandle mergeHandle = new
HoodieWriteMergeHandle(updateTable.getConfig(), "101", updateTable,
- updateRecords.iterator(), updateRecords.get(0).getPartitionPath(),
insertResult.getFileId(), supplier, Option.empty());
+ MergeContext.create(updateRecords.size(), (Iterator)
updateRecords.iterator()), updateRecords.get(0).getPartitionPath(),
insertResult.getFileId(), supplier, Option.empty());
Review Comment:
Addressed in 10279a3b98f4. The lists come out of the test data generators as
raw List<HoodieRecord>, so typing them upstream is not possible; the cast is
now centralized in HoodieClientTestUtils.toTypedRecordIterator with a scoped
@SuppressWarnings, and the call sites no longer cast.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
