rangareddy commented on issue #17339: URL: https://github.com/apache/hudi/issues/17339#issuecomment-5351234446
This issue was reviewed as part of the JIRA-migrated backlog triage (HUDI-8731). **Findings: not implemented on `master`.** I looked for any guard that rejects a change to `hoodie.record.merge.mode` on an existing table and did not find one: - `hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieWriterUtils.scala:228` / `:263` (`validateTableConfig`) is the only table-config validation entry point on the Spark write path, and it carries no immutability rule keyed on `RECORD_MERGE_MODE`. - No "cannot be changed" / immutable-config check for that key exists under `hudi-common/src/main/java/org/apache/hudi/common/table/`. - At the storage layer `HoodieTableConfig.update()` is an unconditional upsert, so nothing stops the write there either. Worth noting this is tightly coupled to #17336 (HUDI-8702), which is about `table update-configs` leaving `hoodie.record.merge.strategy.id` stale when merge mode or payload class change. Both are about the safety of mutating merge configuration after table creation, and a single design covering "which merge configs are immutable, and what is derived from what" would resolve both rather than bolting two independent checks on. Keeping this open. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
