rangareddy commented on issue #17327:
URL: https://github.com/apache/hudi/issues/17327#issuecomment-5351231860

   This issue was reviewed as part of the JIRA-migrated backlog triage 
(HUDI-8747).
   
   **Findings: partially done. The first bullet landed; the second is 
outstanding.**
   
   **Done** - PR #14060, `refactor(spark): Remove glob paths and deprecate read 
paths support` (`2ebc6775dbb6`, merged 2025-11-25), which cites this JIRA 
directly in its description. It throws on glob paths, removed the glob path 
utils and the in-memory file index. `HoodieFileIndex.getQueryPaths` now reads:
   
   ```scala
   private def getQueryPaths(options: Map[String, String]): Seq[StoragePath] = {
     // Treat `path` as fully-qualified (ie non-globbed) path
     val path = options.getOrElse("path",
           throw new IllegalArgumentException("'path' or 'glob paths' option 
required"))
     Seq(new StoragePath(path))
   }
   ```
   
   **Not done** - the incremental-query half. 
`DataSourceReadOptions.INCR_PATH_GLOB` 
(`hoodie.datasource.read.incr.path.glob`) still exists at 
`hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala:160`,
 and is still read and applied by the legacy relations:
   
   - `IncrementalRelationV1.scala:197-200`
   - `IncrementalRelationV2.scala:182`
   
   So the second bullet of this ticket - "Clustering, incremental query going 
through new flow (fg reader), no glob path handling anymore" - has not 
happened; the old relations are still there and still honour the glob pattern. 
PR #14060's own description anticipated this: *"deprecate read paths (I think 
we will remove support in a followup pr)"*.
   
   This ticket is that follow-up. Keeping it open, with the scope narrowed to: 
remove `INCR_PATH_GLOB` and the `IncrementalRelationV1`/`V2` glob handling once 
incremental queries route through the file group reader.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to