rangareddy commented on issue #17388: URL: https://github.com/apache/hudi/issues/17388#issuecomment-5351243107
This issue was reviewed as part of the JIRA-migrated backlog triage (HUDI-5387). **Findings: the base work is done and its JIRA is closed, but the expansion this issue asks for is not. Keeping it open.** Worth separating the two, because the JIRA state is misleading here. **HUDI-5387 is Closed/Fixed** with fix version 1.1.0, and that closure is legitimate for the original "add CLI bundle validation" work - `packaging/bundle-validation/validate.sh` has a `test_cli_bundle()` function at `:301` that runs the CLI against a real bundle and asserts on startup, table creation, connection and `desc` output. But this GitHub issue asks for something the closed JIRA does not cover: *"we have included basic commands for validation, but we can enhance coverage by incorporating additional CLI commands"*. That has not happened. `packaging/bundle-validation/cli/commands.txt` still contains only: ``` create --path file:///tmp/hudi-bundles/tests/table --tableName trips --tableType COPY_ON_WRITE connect --path file:///tmp/hudi-bundles/tests/trips desc commits show exit ``` Five lines, four of them commands. So the bundle is validated for "does the CLI start and can it read a table", and nothing beyond that. Since the validation harness already exists and is wired into CI, expanding it is mostly a matter of choosing which commands are worth guarding and adding assertions for them - `commits showarchived`, `savepoints show`, `cleans show`, `metadata` commands and the table-services commands would each catch a different class of bundle packaging regression. This should not be closed on the strength of HUDI-5387's status. Recommend filing a fresh JIRA for the expansion and relinking this issue to it, so the two are not conflated again. Keeping this open. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
