rangareddy commented on issue #17062:
URL: https://github.com/apache/hudi/issues/17062#issuecomment-5391452185
This issue was reviewed as part of the JIRA-migrated backlog triage
(HUDI-9533).
**Findings: still open.**
**This may already be addressed - it needs one check rather than a fix.**
On `master`,
`hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java:209-212`:
```java
if (isSecondaryIndexStatsStreamingWritesEnabled && !statuses.isEmpty()) {
SecondaryIndexStreamingTracker.trackSecondaryIndexStats(partitionPath,
fileId, getReadFileSlice(),
..., statuses.get(statuses.size() - 1), hoodieTable,
secondaryIndexDefns, config, instantTime, writeSchemaWithMetaFields);
```
Note the shape: a single `getReadFileSlice()` is passed together with the
**plural** `secondaryIndexDefns`. That is exactly what the description asks for
- read the file slice once, then update stats for all secondary indexes.
What I did not establish is whether `SecondaryIndexStreamingTracker`
re-reads the slice per definition internally. If it does not, this ticket is
done and can be closed; if it does, the remaining work is inside that tracker
rather than in `HoodieAppendHandle`. Either way the check is small.
Keeping this open.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
