voonhous commented on code in PR #19709:
URL: https://github.com/apache/hudi/pull/19709#discussion_r3842327988
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/SqlKeyGenerator.scala:
##########
@@ -99,7 +99,15 @@ class SqlKeyGenerator(props: TypedProperties) extends
BuiltinKeyGenerator(props)
override def getPartitionPath(record: GenericRecord): String = {
val partitionPath = originalKeyGen.map {
Review Comment:
Follow-up, please. The mirror is the right end state, but it is a second
behaviour change: for a `TimestampBasedAvroKeyGenerator` delegate a
partition-side `HoodieKeyGeneratorException` stops surfacing from a record-key
lookup, which is unrelated to what #19708 reports. Since this PR is already
gated on #19713 for merge order, keeping it to `getPartitionPath` keeps both
the review and any later bisect clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
