voonhous commented on code in PR #19709:
URL: https://github.com/apache/hudi/pull/19709#discussion_r3850681734
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/SqlKeyGenerator.scala:
##########
@@ -99,7 +99,15 @@ class SqlKeyGenerator(props: TypedProperties) extends
BuiltinKeyGenerator(props)
override def getPartitionPath(record: GenericRecord): String = {
Review Comment:
Bounds check is the right call here; a name check would also change the
long-but-not-meta-prefixed shape, which #19708 does not report.
Ran both suites over `2c14ff2` and over `176abab`: 15/15 green on head, and
on base exactly the five expected reds (`ArrayIndexOutOfBoundsException` x2
from the short-record arms, `HoodieKeyException` x2, `100_1_2`). Resolving.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
