voonhous commented on code in PR #19687:
URL: https://github.com/apache/hudi/pull/19687#discussion_r3844169397
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/utils/SparkInternalSchemaConverter.java:
##########
@@ -82,6 +82,9 @@ public class SparkInternalSchemaConverter {
public static final String HOODIE_QUERY_SCHEMA =
"hoodie.schema.internal.querySchema";
public static final String HOODIE_TABLE_PATH = "hoodie.tablePath";
public static final String HOODIE_VALID_COMMITS_LIST =
"hoodie.valid.commits.list";
+ // Mirrors Spark's VariantMetadata.METADATA_KEY (Spark 4.x only), referenced
by literal
+ // because the class does not exist on Spark 3 classpaths.
+ private static final String SPARK_VARIANT_METADATA_KEY =
"__VARIANT_METADATA_KEY";
Review Comment:
Went one step further: `isVariantRewriteStruct` is now public and
`ParquetSchemaEvolutionUtils.findVariantRewritePath` calls it, so the marker
literal and the every-member rule live in one place; the Scala copy of the
constant is gone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
