hudi-agent commented on code in PR #19687:
URL: https://github.com/apache/hudi/pull/19687#discussion_r3845636233
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/execution/bulkinsert/ConsistentBucketIndexBulkInsertPartitionerWithRows.java:
##########
@@ -86,6 +87,9 @@ public
ConsistentBucketIndexBulkInsertPartitionerWithRows(HoodieTable table,
Map<String,
String> strategyParams,
boolean
populateMetaFields, Map<String, List<ConsistentHashingNode>>
hashingChildrenNodes) {
Review Comment:
🤖 nit: the comment says "itself" twice, which reads a little awkward.
Something like "This strategy sorts within buckets directly rather than
delegating to the custom-columns partitioners, so it must also validate the
sort columns." might flow better. (Same comment is duplicated verbatim in
`RDDConsistentBucketBulkInsertPartitioner`.)
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/execution/bulkinsert/RDDConsistentBucketBulkInsertPartitioner.java:
##########
@@ -74,6 +75,9 @@ public RDDConsistentBucketBulkInsertPartitioner(HoodieTable
table,
super(table,
strategyParams.getOrDefault(PLAN_STRATEGY_SORT_COLUMNS.key(), null),
preserveHoodieMetadata);
+ // This strategy sorts within buckets itself rather than through the
custom-columns
Review Comment:
🤖 nit: same "itself...itself" phrasing as the twin class — could you
harmonise the wording when you update the other one?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
