voonhous commented on code in PR #19164: URL: https://github.com/apache/hudi/pull/19164#discussion_r3879025247
########## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/HoodieSparkValidateDuplicateKeyRecordMerger.scala: ########## @@ -28,9 +28,13 @@ import org.apache.hudi.exception.HoodieDuplicateKeyException import org.apache.spark.sql.hudi.command.HoodieSparkValidateDuplicateKeyRecordMerger.STRATEGY_ID /** - * Validate the duplicate key for insert statement without enable the INSERT_DROP_DUPS_OPT - * config. - * @see org.apache.spark.sql.hudi.command.ValidateDuplicateKeyPayload + * Merger that rejects every merge with a [[HoodieDuplicateKeyException]], for INSERT statements that must fail on a + * duplicate key rather than drop or update it. + * + * No in-repo code path instantiates it since #12588 removed its wiring together with `ValidateDuplicateKeyPayload` Review Comment: Reworded in 32a070759db6 (class doc, test comment, body): never wired in-repo; from #7345 it appeared in production sources only as the TODO in `ProvidesHoodieConfig` that #12588 deleted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
