voonhous commented on code in PR #19164:
URL: https://github.com/apache/hudi/pull/19164#discussion_r3879026870


##########
hudi-spark-datasource/hudi-spark/src/main/java/org/apache/hudi/cli/SchemaProvider.java:
##########
@@ -73,8 +73,9 @@ public HoodieSchema getTargetHoodieSchema() {
       Schema schema = getTargetSchema();
       return schema == null ? null : HoodieSchema.fromAvroSchema(schema);
     } catch (UnsupportedOperationException e) {
-      // If the legacy getTargetSchema() calls getSourceSchema() which is not 
implemented,
-      // fall back to using getSourceHoodieSchema as target schema
+      // Reached by a provider that overrides getSourceHoodieSchema() and 
leaves the deprecated

Review Comment:
   Fixed in 32a070759db6: the class javadoc now names the CLI bootstrap path 
(`BootstrapExecutorUtils` loading the configured implementation by class name) 
and points to `org.apache.hudi.utilities.schema` for the Streamer provider.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to