voonhous commented on code in PR #18816:
URL: https://github.com/apache/hudi/pull/18816#discussion_r3887476766
##########
hudi-cli/src/test/java/org/apache/hudi/cli/commands/TestRepairsCommand.java:
##########
@@ -308,7 +316,7 @@ public void testShowFailedCommits() {
Object result = shell.evaluate(() -> "repair show empty commit
metadata");
assertTrue(ShellEvaluationResultUtil.isSuccess(result));
final List<LogEvent> log = appender.getLog();
- assertEquals(log.size(),4);
+ assertEquals(19, log.size());
Review Comment:
Fixed. Every commit now gets real metadata and a subset is truncated in
place, so the filter is actually exercised.
Restoring the original delete-and-recreate setup does not work on v9:
`createCompleteInstant` mints a fresh completion time, so the rewritten file
stops matching the name the timeline resolves and `TimelineUtils.isEmpty`
throws `HoodieIOException` on the missing path. Truncating at the resolved
filename avoids that.
The expected count is derived from the truncated set rather than a literal,
with a guard asserting it stays a proper subset so the assertion cannot go
trivially true again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
