voonhous commented on code in PR #18816:
URL: https://github.com/apache/hudi/pull/18816#discussion_r3887453833
##########
hudi-cli/src/test/java/org/apache/hudi/cli/commands/TestRepairsCommand.java:
##########
@@ -257,16 +264,16 @@ public void testRemoveCorruptedPendingCleanAction()
throws IOException {
for (int i = 100; i < 104; i++) {
String timestamp = String.valueOf(i);
// Write corrupted requested Clean File
-
HoodieTestCommitMetadataGenerator.createEmptyCleanRequestedFile(tablePath,
timestamp, conf);
+ org.apache.hadoop.fs.Path filePath = new
org.apache.hadoop.fs.Path(metaClient.getTimelinePath() + "/" + timestamp +
".clean.requested");
+
org.apache.hudi.common.testutils.HoodieTestDataGenerator.createEmptyFile(tablePath,
filePath, conf);
}
// reload meta client
metaClient = HoodieTableMetaClient.reload(metaClient);
// first, there are four instants
assertEquals(4,
metaClient.getActiveTimeline().filterInflightsAndRequested().countInstants());
- Object result = shell.evaluate(() -> "repair corrupted clean files");
- assertTrue(ShellEvaluationResultUtil.isSuccess(result));
+ shell.evaluate(() -> "repair corrupted clean files");
Review Comment:
Restored -- the test asserts `ShellEvaluationResultUtil.isSuccess` on the
result again. The command does return success; the assertion had just been
dropped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
