voonhous commented on code in PR #18816:
URL: https://github.com/apache/hudi/pull/18816#discussion_r3888878055
##########
hudi-cli/src/test/java/org/apache/hudi/cli/commands/TestRestoresCommand.java:
##########
@@ -95,6 +95,7 @@ public void init() throws Exception {
// not valid (empty commit metadata, etc)
HoodieMetadataConfig.newBuilder()
.withMetadataIndexColumnStats(false)
+ .enable(false)
Review Comment:
Done in 059d0af2: `HoodieTestTable.of(metaClient)`, writer and column-stats
knob removed.
##########
hudi-cli/src/test/java/org/apache/hudi/cli/commands/TestFileSystemViewCommand.java:
##########
@@ -110,8 +111,9 @@ private void createNonpartitionedTable() throws IOException
{
.makeInlineLogFileName(fileId1, HoodieLogFile.DELTA_EXTENSION,
commitTime2, 0, testWriteToken)));
// Write commit files
- Files.createFile(Paths.get(nonpartitionedTablePath, ".hoodie", commitTime1
+ ".commit"));
- Files.createFile(Paths.get(nonpartitionedTablePath, ".hoodie", commitTime2
+ ".commit"));
+
Files.createDirectories(Paths.get(metaClient.getTimelinePath().toString()));
Review Comment:
Done in 059d0af2: `FileCreateUtils.createCommit` at all four sites.
##########
hudi-cli/src/test/java/org/apache/hudi/cli/commands/TestRepairsCommand.java:
##########
@@ -257,16 +262,17 @@ public void testRemoveCorruptedPendingCleanAction()
throws IOException {
for (int i = 100; i < 104; i++) {
String timestamp = String.valueOf(i);
// Write corrupted requested Clean File
-
HoodieTestCommitMetadataGenerator.createEmptyCleanRequestedFile(tablePath,
timestamp, conf);
+ Path filePath = new Path(metaClient.getTimelinePath() + "/" + timestamp
+ ".clean.requested");
+ HoodieTestDataGenerator.createEmptyFile(tablePath, filePath, conf);
Review Comment:
Done in 059d0af2: helper call restored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
