voonhous commented on code in PR #18816:
URL: https://github.com/apache/hudi/pull/18816#discussion_r3888878591
##########
hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java:
##########
@@ -623,7 +623,7 @@ private static void withMetaFieldsModeOf(JavaSparkContext
jsc, String basePath,
}
}
- private static int archive(JavaSparkContext jsc, int minCommits, int
maxCommits, int commitsRetained, boolean enableMetadata, String basePath) {
+ protected static int archive(JavaSparkContext jsc, int minCommits, int
maxCommits, int commitsRetained, boolean enableMetadata, String basePath) {
Review Comment:
Done in 059d0af2: `@VisibleForTesting`, and the test comment names
TestArchiveCommitsProcedure.
##########
hudi-cli/src/test/java/org/apache/hudi/cli/commands/TestRepairsCommand.java:
##########
@@ -408,6 +425,7 @@ public void testRenamePartition() throws IOException {
JavaRDD<HoodieRecord> writeRecords =
context().getJavaSparkContext().parallelize(records, 1);
List<WriteStatus> result = client.upsert(writeRecords,
newCommitTime).collect();
Assertions.assertNoWriteErrors(result);
+ client.commit(newCommitTime, jsc().parallelize(result));
Review Comment:
Done in 059d0af2: `assertTrue(totalRecsInOldPartition > 0)`.
##########
hudi-cli/src/test/java/org/apache/hudi/cli/commands/TestCleansCommand.java:
##########
@@ -86,7 +86,7 @@ public void init() throws Exception {
// Create table and connect
new TableCommand().createTable(
tablePath, tableName, HoodieTableType.COPY_ON_WRITE.name(),
- "", TimelineLayoutVersion.VERSION_1,
"org.apache.hudi.common.model.HoodieAvroPayload");
+ "", HoodieTableVersion.current().versionCode(),
"org.apache.hudi.common.model.HoodieAvroPayload");
Review Comment:
Leaving as is: the explicit version documents the fix, and the unused
overload is out of scope here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
