voonhous commented on code in PR #19808:
URL: https://github.com/apache/hudi/pull/19808#discussion_r3912765889
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieStorageConfig.java:
##########
@@ -308,22 +310,28 @@ public class HoodieStorageConfig extends HoodieConfig {
public static final ConfigProperty<Boolean>
PARQUET_VARIANT_SHREDDING_SCHEMA_INFERENCE_ENABLED = ConfigProperty
.key("hoodie.parquet.variant.shredding.schema.inference.enabled")
- .defaultValue(false)
+ .defaultValue(true)
Review Comment:
Reordered by cost: the inferrer lookup (a static field) goes first, so a
Spark 3.x or 4.0 classpath pays nothing; then a scan of the StructType argument
for a top-level variant through the adapter's `isVariantType`; only a variant
table on an inferring classpath then reaches
`getInferableVariantColumnsFromConfig` and its parse. The other two factories
already gate on their parsed schema argument; this one now does the equivalent
on its StructType.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
